Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webp: Fix Issue 2763 #2767

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Webp: Fix Issue 2763 #2767

merged 4 commits into from
Jul 10, 2024

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes #2763 with encoding lossless webp images with a specific quality setting.

JimBobSquarePants
JimBobSquarePants approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TheUniverseTimAndEricMindBlownGIF

I'm SO impressed you found this. I spent hours over the weekend looking at it and wen't far too deep down the rabit hole comparing the backward reference code. Well done!!

@JimBobSquarePants JimBobSquarePants merged commit 10e9c49 into main Jul 10, 2024
5 checks passed
@JimBobSquarePants JimBobSquarePants deleted the bp/Issue2763 branch July 10, 2024 10:28
@JimBobSquarePants JimBobSquarePants mentioned this pull request Jul 10, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
bug formats:webp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webp encoding produces completely transparent images
2 participants
@brianpopow @JimBobSquarePants